[PATCH] Postprocessing of commit message from external editor

Martin Pool martinpool at gmail.com
Tue Oct 4 07:39:13 BST 2005


On 03/10/05, Wouter van Heyst <larstiq at larstiq.dyndns.org> wrote:
> On Sun, Oct 02, 2005 at 12:47:36PM +0200, Wouter Bolsterlee wrote:
> > P? Sat, Oct 01, 2005 at 10:05:21PM +0300, Alexander Belchenko skrev:
> > > I propose to change post-processing of commit message from external
> > > editor by deleting last newline symbol. Proposed patch attached.
> >
> > What about stripping all _trailing_ (not leading) whitespace from the commit
> > message? I don't see any situation in which trailing whitespace is useful.
>
> I'd rather my commit messages aren't touched so I don't have to
> transform them again when used in other situations.

Any other opinions?  In general we should respect the user's input but
trailing whitespace here is probably not very helpful and messes up
the log.

Perhaps the answer is that the log formatter should tidy it up.

--
Martin




More information about the bazaar mailing list