bzr questions

[Martin Pool]

On 29/09/05, David Allouche <david at allouche.net> wrote:

> I think it would make sense to squelch the error for observer commands
> (like log) where he output is the only desired result.
>
> For mutator commands like commit, branch, merge, etc. I think the
> warning is definitely worthwile, but should probably be made a bit more
> explicit, something like "Broken pipe, COMMAND did not complete. Maybe
> you used "less" and quit without scrolling to the end.".

This sounds good to me.  So we should leave the message in
run_bzr_catch_errors, and just intercept EPIPE in particular cases
such as log where it's OK for the output to be interrupted.

> Extra points for only printing the warning only if the requested side
> effect was not achieved. More extra points for buffering output in
> mutator commands so that the side effect is achieved even if stdout or
> stderr was broken.

Well, I guess you could have a file wrapper object that, when the
underlying file's pipe is broken, just discards output from that point
on.  It might be nice for things like commit, thought not urgent. 
Certainly commit should either happen as close to atomically as we can
manage.

--
Martin