[PATCH] Proper error message when specifying empty commit message

Robert Collins robertc at robertcollins.net
Thu Oct 6 06:15:36 BST 2005


On Wed, 2005-10-05 at 23:57 -0500, John A Meinel wrote:
> Robert Collins wrote:
> > On Sun, 2005-10-02 at 15:19 +0200, Jelmer Vernooij wrote:
> >
> >>Hi Robert,
> >>
> >>Sorry about the late reply.  Thanks for the feedback.
> >
> >
> > I tried to pull this, couldn't connect to your branch.
> >
> > Cheers,
> > Rob
> >
> >
> You might try my mirror of his branch at:
> http://bzr.arbash-meinel.com/mirrors/bzr-jelmer
> 
> I think it is the same branch.

Hmm, not sure. I've merged it in anyway, with a couple of tweaks...
there were tabs in setup.py, and the test depended on 'touch' which may
not exist on win32 - so I changed the test to use 'bzr commit -m ""' -
which is equally invalid. Jelmer - please have a look at the resulting
code - there was a problem with your patch in that it would ignore empty
commit messages coming from files or the -m parameter. (At least, I
interpreted that as a problem, if it was deliberate, we can change
this).

Cheers,
Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051006/b33fd78a/attachment.pgp 


More information about the bazaar mailing list