plugin: sftp transport

[John A Meinel]

Robey Pointer wrote:
>
> On 19 Oct 2005, at 6:36, John Arbash Meinel wrote:
>
>>> Also, you have it require paramiko, which means that you can't even  run
>>> bzr anymore.
>>>
>>> The exception really should be such that if it can't load the sftp  code,
>>> that it at most gives a warning and continues.
>>>
>>> That way people who chose not to install paramiko yet, don't have to,
>>> and still have full usability for a local system.
>
>
> I agree.  How about letting plugins raise an exception
> ("PluginFailedException"?) which causes bzr to silently ignore the
> plugin.  That way, the SFTP plugin could immediately abort when
> paramiko fails to load (possibly logging a warning?), but not hook
> itself into bzr and not cause bzr to abort.
>

Actually, plugins that fail to load are warned about and fail. The issue
is that he made it part of core bzr, which is required to load. Right
now bzr.dev is completely broken on my machine, unless I go back and
hack out the import (or install paramiko). I can't bzr revert back to an
earlier revision, because bzr always fails while loading.

Since he merged it into the core, you probably should focus your
attention there, as far as future patches, rather than focusing on a plugin.
Though you might wait for him to clean things up first, since he will
most likely do some work that way. (I think he would like to see your
work on having the tests run, though).

John
=:->

> robey
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 253 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051019/4a57e069/attachment.pgp