[PATCH] FTP transport

[Daniel Silverstone]

On Thu, 2005-11-17 at 23:40 +0100, Matthieu Moy wrote:
> > I've written a patch which fixes a 'put' related issue and also covers
> > this eventuality by seriously forcing one connection per
> > host/user/pass/active four-tuple
> Seems to work for me.

Excellent.

> I still have a problem with my provider: It's closing the connection
> periodically (that's a known problem with this ISP), so bzr stops with
> bzr: ERROR: ftplib.error_temp: 425 Can't open data connection.
>   at /usr/lib/python2.4/ftplib.py line 212
>   in getresp
> and I have to re-run it several times up to completion. It would be
> great if bzr could try to reconnect when an operation fails (many ftp
> clients do this seamlessly). I don't know whether this should be in
> transport of ftp.

I guess if I get an error_temp I could attempt a reconnection and re-try
the operation. at least error_temp is theoretically a re-tryable
operation.

> > Yeah. The other issue is that even after it completes successfully, only
> > the .bzr dir will be populated, it won't be a working tree of any
> > usefulness, but it works fine for merge/branch
> Yes, but that's bzr push's behavior, not the transport layer.

Right.

D.

-- 
Daniel Silverstone                         http://www.digital-scurf.org/
PGP mail accepted and encouraged.            Key Id: 2BC8 4016 2068 7895