Strip trailing whitespace from comments

John A Meinel john at arbash-meinel.com
Mon Nov 21 15:47:36 GMT 2005


John A Meinel wrote:
> Wouter Bolsterlee wrote:
>> Hi,
>>
>> I'm wondering why bzr commit does not strip empty lines at the end of commit
>> messages before doing the actual commit. The output of bzr log shows an
>> empty line between some commit messages and no line between others, since I
>> mix  bzr ci -m '* Fixed foo'  and the editor-based  bzr ci.
>>
>> Is this intended behaviour?
>>
>>   mvrgr, Wouter
>>
> 
> I believe we should not change the actual commit message that is stored.
> However, I think when we display the message, we can strip the extra lines.
> 
> I've committed a fix into my integration branch here:
> http://bzr.arbash-meinel.com/branches/bzr/jam-integration/
> 
> Revno 1341 is the change, and 1342 will be the test case.
> 
> I'm writing up a test for it now. But it does what I expect it to.

The test case has been written, and everything seems correct. I also
found a small bug where the short log formatter wasn't printing the
extra spacer line to 'to_file' it was always printing it to stdout.

John
=:->

> 
> John
> =:->
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051121/755010eb/attachment.pgp 


More information about the bazaar mailing list