branch: sftp fixes

John A Meinel john at arbash-meinel.com
Tue Nov 22 02:19:48 GMT 2005


Robey Pointer wrote:
> In the interest of waving a red flag and trying to expedite getting
> these into the bzr mainline, I made a special branch that just holds the
> sftp fixes from the last couple of weeks.  Here are the changes
> incorporated:
> 
> * make sftp put faster when using paramiko 1.5.1
> * fix sftp urls to support the ietf draft url spec wrt relative vs
> absolute sftp urls (this will break existing branch urls); fix
> username/password parsing in sftp urls; add unit tests to make sure sftp
> url parsing is working
> * modified patch from alexey shamrin & john meinel to stdout-encode the
> getpass prompts within sftp transport
> * tighten up the sftp unit tests a bit to make them work better on windows
> * patch from erik to fix sftp relpath to only check the path component
> * modified version of john's patch to add atomic put and locking to the
> sftp transport
> 
> 
> The branch is here:
> 
>     http://www.lag.net/~robey/bzr.sftp
> 
> robey
> 
> 
> 

I think I already merged these into my own sftp fixes branch here:
http://bzr.arbash-meinel.com/branches/bzr/sftp-fix/

On top of your changes, I added a weakref caching to sftp connections. I
also modified some of your changes, such as using hasattr rather than
catching an AttributeError exception (the latter could be thrown inside
rather than just at the top).
I also switched the sftp tests back to not being lazy, because
delayed_setup broke the sftp branch tests. And the only reason we
switched to delayed was because a couple of tests hadn't actually been
written yet. Far better to just write those tests.

I haven't merged these into my integration branch, because I wanted to
review them a little bit more. But I probably will merge it some time
this week.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051121/1cb42928/attachment.pgp 


More information about the bazaar mailing list