[PATCH] Re: any more sftp fixes?

[John A Meinel]

Matthieu Moy wrote:
> John A Meinel <john at arbash-meinel.com> writes:
> 
>> Alright, I've fixed that bug, and added a test case. Can you give it
>> another try?
> 
> Worksforme :-)
> 
> [ now looking forward the remote working tree things ]
> 

Well, actually, I just tracked down the problem. And it is a problem
with the separation between what is in WorkingTree and what is in
Branch. It seems to have been introduced in patch 1449 from Johan
Rydberg (patch by Martin).

Specifically, this line was added:
self.working_tree().set_last_revision(new_revision, old_revision)

So after something calls "append_revision()" the working tree is told to
set what it believes is the last revision.

However, if the working tree hasn't actually been updated, is it
actually correct to do that?

Anyway, I'll hack around it in my integration branch, with a try:except
to not try and update a working tree if we don't have one.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051130/7d12ea4d/attachment.pgp