[Bug] bzr diff -r 4.. == bzr diff -r 4..0

[Michael Ellerman]

Hi,

I expect bzr diff -r 4.. to give me the diff between 4 and the working tree. 
Instead it gives me the diff between 4 and 0 - I'm pretty sure it use to do 
the former.

I think this probably broke when revision specs went in, in show_diff() in 
bzrlib/diff.py I see:

    if revision2 is None:
        if b2 is None:
            new_tree = b.working_tree()
        else:
            new_tree = b2.working_tree()
    else:
        new_tree = b.revision_tree(revision2.in_history(b).rev_id

When I specify -r 4.. revision2 isn't None, it's RevisionSpec(None).

What's the right way to test for this? It wasn't immediately obvious in the 
RevisionSpec API how to check for it.

cheers

-- 
Michael Ellerman
IBM OzLabs

email: michael:ellerman.id.au
inmsg: mpe:jabber.org
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051201/566d186e/attachment.pgp