'bzr status' stats each file multiple times

[John A Meinel]

Aaron Bentley wrote:
> John A Meinel wrote:
> | I have a rather large .bzrignore, because this project
> | likes to build inside the tree. It's a rather large project with 1600
> | source files, and about 50 output executables.
> | So I think bzr is trying to match each file it finds against all entries
> | in .bzrignore.
> 
> I don't know what it *is* doing, but it should only be checking
> unversioned files against .bzrignore.
> 
> | Since a lot of them are absolute paths, I'm thinking bzr should use a
> | dictionary for the absolute paths, then it can just say "is path in
> | ignored_paths" rather than doing a fnmatchcase against each one. 50x500
> | files takes a while.
> 
> Since absolute paths may have wildcards, that's not entirely right.  But
> non-wildcard absolute paths are common, so it may be worthwhile to
> optimize for them, as long as the external behavior doesn't change.

Right, I noticed that as well when I started to look at it. What
wildcards do we support, so that I can look for them? I believe just *
and ?, though we might also do [], etc.

I still have 50xa large number of comparisons. (Since it also compares
against all *.o files)

I want to test and see if it is faster. And then we can decide if we
want to incorporate it.

John
=:->

> 
> Aaron

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051204/1751a02f/attachment.pgp