[RFC] and/or [MERGE] bzr add reports ignored patterns.

[John Arbash Meinel]

Aaron Bentley wrote:
> Hi all,
> 
> On IRC, we just discussed how configure.in shouldn't be in the default
> ignores, and I agree.
> 
> I think default ignores are very nice in general, but they won't work
> properly for everyone (some people use autoconf, but not automake, for
> example).

I've ran into that same problem, where Makefile.in was ignored. I
noticed, and just added them all manually.

> 
> So to avoid things silently going wrong, I've changed the bzr add output
> so that each ignore pattern is mentioned once:
> 
> ~/bzr.ab$ bzr add
> $ bzr add
> added README
> ignored 141 file(s) matching "*.py[oc]"
> ignored 2 file(s) matching ".*.sw[nop]"
> ignored 1 file(s) matching "bzr.1"
> If you wish to add some of these files, please add them by name.
> 
> This actually communicates a bunch of useful info:
> 1. A number of files that you may have wanted to add were ignored.
> 2. Even ignored files can be added, you just have to specify them by name.
> 3. Ignore patterns are globs.

I would only print out the ignored files that are checked. So if I do:
bzr add foo
It shouldn't tell me other files were ignored.

I would also only print 'If you wish to add...' if it printed out that
there were ignored files.

If you haven't done it, this should probably use blackbox tests.

You didn't give a branch where you did this, so it is really difficult
to review your actual changes and merge them. :)

> 
> Aaron
> 
> P.S. I would prefer if any bzr output that resembles a sentence (e.g.
> "added FOO", "ignored BAR") began with a capital letter.  Does anyone
> else want that?

If you aren't repeating yourself, then I agree. So if you said:

Ignored 141 files matching "*.py[oc]", 2 files matching ".*.sw[nop]",
and 1 file matching "bzr.1".

Then I would start it with a capital letter.
But if you are saying:

added a
added b
added c
added d

I prefer the lower case to:
Added a
Added b
Added c
Added d

But I'm not really picky.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051213/ed125213/attachment.pgp