[MERGE REQUEST] Couple of small fixes

[John Arbash Meinel]

Jelmer Vernooij wrote:
> Hi Robert,
> 
> Thanks for your comments. I'll fix the issues you mentioned, not sure
> about one thing though (see below).
> 

...

> 
> I don't really see how this makes opening containing branches slower.
> 
> There are two approaches that can used for 'open_containing': 
> depth-first and breadth-first search for a Branch. I've implemented
> depth-first search because it does not make opening bzr branches
> slower even if you have a several foreign branch classes loaded (since
> it will try Bzr first).

The big problem is it may mean trying to reconnect to a remote host
multiple times.

At the point you have, 'url' is simply a string. While a Transport
frequently has an open connection.

> 
> The code you are looking at here which searches for a .bzr branch by going down one level at a time was previously in Branch.open_containing. I moved it to 
> BzrBranch since not all derived classes of Branch may be using Transport.

Now, one thing I'm not sure about, though, is that if you are doing say
a "svn" branch. Do you use svn:// notation, or are you just supplying a
path, and recognizing it is an SVN branch because it has the appropriate
.svn/_svn directory?

'svn://' notation would require to be parsed directly by the branch
class, since we wouldn't register a tranport type for svn. The latter
would work just fine with a simple Transport object.

> 
> Cheers,
> 
> Jelmer

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051215/cf7b336a/attachment.pgp