bzr check

John Arbash Meinel john at arbash-meinel.com
Fri Dec 16 22:19:03 GMT 2005


I went through the 'bzr check' code, and I notice it is doing this:
        if rev.inventory_sha1:
            inv_sha1 = branch.get_inventory_sha1(rev_id)
However, branch.get_inventory_sha1 has been redefined as
"get_revision().inventory_sha1"
Which means that it is just regurgitating what was stored there. That
doesn't seem quite right.

The other thing it fails to do is to check that the hash in the weave
toc matches the measured hash. It does make sure that get_file_lines()
hash matches that of the inventory, which might be good enough.

John
=:->
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051216/37bd4594/attachment.pgp 


More information about the bazaar mailing list