[rfc][patch]

[John A Meinel]

Erik Bågfors wrote:
> I've implemented "bzr pull --revision X". Well, most of the
> functionality was already there, I just exposed it in the ui.
> 
> I am not sure about the code, am not used to python and haven't done
> anything inside bzr almost. So feel free to call me an idiot in the
> way I wrote the code.  Comments are welcome.
> 
> I also added a test case but I can't get the standard test suite to
> pass so I can't even get it to my code. So the test is totally
> untested :)
> 
> Get it from http://erik.bagfors.nu/bzr.pull-revision
> 
> Merry Christmas all.
> 
> Regards,
> Erik
> 
> 

I'll start looking over this and give you some feedback. But I wanted to 
mention a couple of things for you.

First, the test suite allows you to supply a regex, which it will use to 
only run specific tests. So you can run:

bzr selftest transport

And it will only run tests which have the word 'transport' in them.

Or you can say
bzr selftest 'pull.*revision'
And it will only run specific tests.
I find it useful to run:

BZR_PLUGIN_PATH='' ./bzr selftest --verbose --one 'tests-im-working-on'

While I'm trying to get some tests to pass. When I'm done, I make sure 
to go back and run:

BZR_PLUGIN_PATH='' ./bzr selftest

In my case, I need the BZR_PLUGIN_PATH (or ./bzr --no-plugins), because 
I have some plugins which break the test suite. (Alternate log formatter 
is the big one).

John
=:->