problems with encodings for signed commits

[John A Meinel]

Dafydd Harries wrote:
> The explanation here is rather lengthy, in the hope that it might save people
> time in working out what the correct behaviour should be. I think this ties in
> with the recent discussion about how bzr should deal with encodings, and
> perhaps it might be illuminative in that regard also.
> 
> While importing a baz branch into bzr recently, I discovered that the
> testament code fails if a commit message contains non-ascii characters. The
> error ocurred when the code attempts to get an SHA of a unicode object
> returned by Testament.as_text_lines, which proclaims:
> 
>     def as_text_lines(self):
>         """Yield text form as a sequence of lines.
> 
>         The result is returned in utf-8, because it should be signed or
>         hashed in that encoding.
>         """
> 
> There is code that checks that the method doesn't return a unicode object, but
> it's guarded by an "if __debug__", which I consider to be a bit odd.

Well, __debug__ is only turned off when you supply the -O flag, so in
the common case it should still be running.

What surprises me is that it works at all, though. Considering that most
of those fields should be unicode.

> 
> The unicode object in question originates in Commit.commit:
> 
>         if isinstance(message, str):
>             message = message.decode(bzrlib.user_encoding)
> 
> This object ends up in the new Revision object, which is used by
> Testament.as_text_lines, which is used by Testament.as_short_text, which tries
> to SHA the message whether it's unicode or not. Boom.
> 
> I have a branch with a test case, and a potential fix. No idea if the fix is a
> good one, but it was enough to get me the import I wanted.
> 
> http://muse.19inch.net/~daf/bzr/bzr/devel/
> 

The fix seems about right to me. Though I don't know if we should just
always be encoding into utf-8.

John
=:->

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20051228/c26a2c12/attachment.pgp