storage branch & mode changes

[John Arbash Meinel]

Robert Collins wrote:
> On Tue, 2006-01-03 at 15:26 -0600, John Arbash Meinel wrote:
> 
>>Robert Collins wrote:
>>
>>>I've merged integration to my copy of the storage branch, and resolved
>>>most of the issues, but the mode stuff John did recently is making me
>>>cry - 
>>>John, any chance you could have a peek ?
>>>
>>>http://people.ubuntu.com/~robertc/baz2.0/storage/
>>>
>>>Rob
>>
>>I had a look, and my changes are in:
>>http://bzr.arbash-meinel.com/branches/bzr/storage/
>>
>>Basically, I moved the mode permissions from Branch into LockableFiles.
>>As I recall, we had discussed that in the future we would want
>>.bzr/repository to possibly have different permissions from .bzr/checkout.
>>
>>Also, I changed LockableFiles so that rather than taking a transport and
>>a base directory, it just takes a transport.
>>That also meant we don't need _rel_controlfilename anymore, because all
>>control files are created in the local directory. It caused some other
>>changes, where code that didn't really need _rel_controlfilename was
>>using it. But I think I got all those cases.
> 
> 
> Thanks!. There was a failing test__escape which I've fixed, and I've put
> in the need to update the tests that currently test via branch to test
> lockable files directly.
> 
> I've also updated my email plugin which is now at
> http://people.ubuntu.com/~robertc/baz2.0/plugins/email/storage for the
> current storage api. I'll be doing bzrtools (to
> plugins/bzrtools/storage) shortly.
> 
> Cheers,
> Rob
> 

You know what happened? I had accidentally renamed both tests to
test__escape. So the second test was always passing. Then I saw the name
conflict, and fixed it, but didn't think to rerun the test.

John
=:->

PS> I guess I would like to review the changes again if anything major
is done. But otherwise I'll give it a +1.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 256 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060104/a68735f9/attachment.pgp