[patch] deprecation warnings branch

Robert Collins robertc at robertcollins.net
Thu Jan 5 21:46:49 GMT 2006


On Thu, 2006-01-05 at 10:33 -0600, John Arbash Meinel wrote:

> The only thing I miss is seeing the function signature. Specifically,
> just doing help(bzrlib.get_bzr_revsion) gives:
> 
> Help on function get_bzr_revision in module bzrlib.symbol_versioning:

Oh, I missed the wrong module. I'll fix that trivially (same as
__name__)

> get_bzr_revision(*args, **kwargs)
>     If bzr is run from a branch, return (revno,revid) or None.
> 
>     This function was deprecated in version 0.7.
> 
> Obviously the module is wrong, and the arguments have disappeared.
> But I think you are genuinely correct that it isn't worth it for
> functions which we are deprecating. We are specifically saying 'don't
> use these', so it doesn't matter if they are a little harder to use. :)

Right. Separate issue though, @needs_read_lock and @needs_write_lock
have the same issues.

> So +1 for deprecation, and the code seems clean.

Thanks, Current version in integration, and I'll have up a module fixing
one asap.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060106/62772683/attachment.pgp 


More information about the bazaar mailing list