default ignores don't ignore '.swp'

[Jan Hudec]

On Mon, Jan 09, 2006 at 10:13:28 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> John Arbash Meinel wrote:
> > Aaron Bentley wrote:
> > Really. Having .bzrignore doesn't override the defaults as far as I can
> > tell. It just adds to them.
> 
> It used to.  Here's the code from revision 101:
> 
>     def get_ignore_list(self):
>         """Return list of ignore patterns."""
>         if self.has_filename(bzrlib.IGNORE_FILENAME):
>             f = self.get_file_byname(bzrlib.IGNORE_FILENAME)
>             return [line.rstrip("\n\r") for line in f.readlines()]
>         else:
>             return bzrlib.DEFAULT_IGNORE
> 
> 1. the defaults are used if there's no .bzrignore
> 2. the first time the 'bzr ignore' command is used, the defaults are
> copied into .bzrignore (as well as your input)
> 3. from then on, it only uses .bzrignore to determine the patterns to
> ignore.

Yes, I'd consider that a reasonable behaviour. In fact I'd even consider it
should simply write .bzrignore in bzr init.

> > Basically, .bzrignore is things you want to ignore *on top of* what bzr
> > defaults to ignoring.
> 
> I believe that change was a bad idea.  It appears to have been made in
> revision 102, but I still think it's wrong.
> 
> > Which is why Makefile.in should not be in the default ignores. You can
> > easily type 'bzr ignore Makefile.in' if they are autogenerated, but you
> > can't get rid of a default ignore.
> 
> I believe there needs to be a way to override the default ignores.  But
> if you currently cannot, then I agree that Makefile.in should not be in
> them.  I'd add that .pyc should also not be in them, since it may be
> source for some projects.

I would personaly argue that *nothing* should be in defaults that can't be
overriden.

-- 
						 Jan 'Bulb' Hudec <bulb at ucw.cz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060109/1234184c/attachment.pgp