[rfc] [patch] trivial patch to speed up bzr log

[Robert Collins]

On Thu, 2006-01-12 at 21:14 +0100, Denys Duchier wrote:
> before the patch:
> 
>      $ time bzr log NEWS >/dev/null
>      
>      real       4m36.264s
>      user       4m21.360s
>      sys        0m2.072s
> 
> after the patch:
> 
>      $ time bzr.cleanup log NEWS >/dev/null
>      
>      real       2m43.820s
>      user       2m39.778s
>      sys        0m1.421s
> 
> 
> The trick is simply to cache in the weave object the last extracted revision.
> This matches exactly the extraction pattern occurring during "bzr log".

I'm concerned that this will double the memory footprint of bzr in large
trees. (with -v on launchpad for instance, I'd be anticipating an 800Mb
memory footprint with this change.)

Caching an inventory as happens later in the thread is less of an issue
for me - there is only one per branch :).

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060116/928b2f09/attachment.pgp