Getting rid of RootEntry?

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
| #1 sounds reasonable to me.  It looks like not much else in the code
| cares about the type of it and

Great.

| There are some other flaws there in how the root entry is handled: it's
| returned by iter(Inventory) but not Inventory.iter_entries.  If we take
| this path perhaps we should always return it along with other files and
| expect callers to handle it.  I wouldn't change the existing methods'
| behaviour but perhaps we can at least decide how to do it for new ones.

For new methods, (and eventually, for all of them,) I'd prefer to return
the root id.  Right now, I feel like some kind of medieval torturer
whenever I extract the root ID: "Admit it, Working Tree, you know the
name of the root ID.  Just tell me now, and I can make all the pain go
away.  Why are you making it harder on yourself?"

| We can do #1 now and perhaps #3 later.

That sounds great to me.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDzbGz0F+nu1YWqI0RAuHHAJwPoxvnKsJUmwSeT1ZYVsYnMZJ4vACdHqfS
Fx79Bm1wVuuAyNKq85o40D0=
=9RoF
-----END PGP SIGNATURE-----