[merge] Make merge internals private

Aaron Bentley aaron.bentley at utoronto.ca
Mon Jan 23 18:20:07 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Could I get a review please?

Same old place:
http://panoramicfeedback.com/opensource/bzr/bzr.ab/

Martin Pool wrote:

>>>Perhaps if this is meant to
>>>be a bzrlib-internal class it would be better called
>>>_MergeConflictHandler.  (In which case it could go back in merge.py if
>>>you wanted :-)

This is done.

I have moved merge.merge into builtins so that we don't open branches
outside the UI level, as John Meinel suggested.

I have reduced the PEP8 violations.

get_tree and get_revid_tree are now private.

I have removed file_exists.

I have not removed build_working_dir, but I have explained why I think
it should not be removed.

I have not made merge_inner or Merge private, but I have explained why I
think they should be public.

I have not made MergeConflictHandler public, but I have explained why I
think it should not be public.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFD1R5W0F+nu1YWqI0RAt+zAJ42ZIO9UBz9HNd/ot4efRJ2eKmcIwCeOGIQ
ltFq6AtnmiytKiLWoZRhmJI=
=uarG
-----END PGP SIGNATURE-----




More information about the bazaar mailing list