Revision spec issues

[John A Meinel]

James Blackwell wrote:
> On Sun, Feb 12, 2006 at 06:47:54PM -0600, Matthew D. Fuller wrote:
>> There are a couple difficulties currently with revision specs; mostly,
>> inconsistencies between what's said to work, and what does work.
>>
>>
>> 1) 0.7 fixed the issue of ranges with no upper bound (e.g, "5.."), but
>>    neither 0.7 not bzr.dev handle ranges with no lower bound ("..5"),
>>    which "should" work according to the wiki and comments in the code.
>>    I'm not sure it really matters if we don't support it;
>>    "1..<whatever>" is virtually as easy to type (as opposed to
>>    "<whatever>..-1", which is a little less intuitive), but the docs
>>    and the code really should line up either way.
> 
> It does? As far as I can tell, ranges don't work at all. My bzr.dev client
> does the following: 

Some of these have been fixed in my integration branch. I don't remember
exactly who I merged (I might have merged the changes directly, or I
might have merged bzr-0.7).

Either way you get:
$ ./bzr log -r 1530..
 1530 John Arbash Meinel        2006-02-12
      [merge] fix weave join to display nicer progress messages.

 1531 John Arbash Meinel        2006-02-13
      [merge] bzr.ab, several small bugfixes.

$ ./bzr log -r ..5
bzr: ERROR: Invalid revision number 0

...

> 
>> 2) Date specs by name (today, etc) don't act like they're documented
>>    to.  Both the docstrings in the code and the wiki [I just changed
>>    the latter] say that "date:today..date:tomorrow" should refer to
>>    "all revisions today", but trying to actually DO that fails:
> 
>>    % bzr log -rdate:today..date:tomorrow
>>    bzr: ERROR: Branch BzrBranch(u'/tmp/bzr/dtest/') has no revision
>>         date:tomorrow
>>
>>    "date:yesterday..date:today", however, DOES appear to work
>>    correctly.  I don't have the knowledge of Python to tell whether it
> 
> This doesn't seem to be working either. Are you using a different bzr.dev
> than I am?
> 
> jblack at pluto:~/branches/bzr.dev$ bzr log -rdate:yesterday..date:today
> bzr: ERROR: Branch BzrBranch(u'/home/jblack/branches/bzr.dev/') has no
> revision date:yesterday

I think the issue is that you don't have any commits yesterday or today.
So there is nothing for it to display. And unfortunately it leads to an
ERROR rather than just saying "nothing to display" or something like that.

bzr.dev hasn't been updated in quite some time (Feb 2nd is the last commit).

I agree that the date: markers probably need some work. I don't know
anyone who is using them. When I originally wrote them 'yesterday',
'today' and 'tomorrow' where defined as exact timestamps, and then the +
would search for something *after* that timestamp, and the - for
something before that timestamp. So doing date:-today, could go back a
few days until it found the first thing before 12:01am this morning.

I don't know how it evolved, but it definitely could use some love and care.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060214/339aabee/attachment.pgp