[MERGE REVIEW]
Robert Collins
robertc at robertcollins.net
Thu Feb 23 00:11:21 GMT 2006
+1 with a couple of tweaks
Firstly, I think its nice when deprecated an api to provide a forward
pointer in the docstring - so in the docstring of show_status, have
'Please use show_tree_status now.' or similar.
Cheers,
Rob
On Wed, 2006-02-22 at 19:02 -0500, Aaron Bentley wrote:
> @@ -90,8 +93,11 @@
>
> tof = StringIO()
> revs.append(RevisionSpec(1))
> -
> - show_status(b, to_file=tof, revision=revs)
> +
> +
> +
> +
> + show_tree_status(wt, to_file=tof, revision=revs)
That seems like an awful lot of vertical white space.
> +class CheckoutStatus(BranchStatus):
> + def setUp(self):
PEP8: a line between class and setUp:
class Foo:
def first_class_scope_thing(self):
Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060223/508a3e63/attachment.pgp
More information about the bazaar
mailing list