[Bug 32526] uncommit -r off by one

[James Blackwell]

On Wed, Feb 22, 2006 at 06:09:24PM -0600, John Arbash Meinel wrote:
> > Description:
> > As of revision 1543 runnin "bzr uncommit -r revno" is off by one
> > revision. If one wants to return to revsision "1528" then one needs to
> > specify revision "1529"
> > 
> 
> That is actually the design. 'uncommit -r' is saying 'uncommit this
> revision', versus 'revert' which is saying 'revert *to* this revision'.
> 
> Now, I can agree that the distinction is minor. And I've found myself
> saying "uncommit *to* this revision". So we may want to change the
> semantics of the command.

I'm not strong on it. The rational for current makes sense and is
describable.

I think that it would be a little easier to support -r
WhatYouWant.



> I'm sending this to the mailing list so that we can have a discussion
> about what 'uncommit -r' should mean.
> 
> John
> =:->
> 
> 



-- 
My home page:   <a href="http://jblack.linuxguru.net">James Blackwell</a>
Gnupg 06357400  F-print AAE4 8C76 58DA 5902 761D  247A 8A55 DA73 0635 7400
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060222/63d548eb/attachment.pgp