Bazaar pqm supports 'rio' requests

Robert Collins robertc at robertcollins.net
Fri Feb 24 12:35:50 GMT 2006


On Thu, 2006-02-23 at 23:42 -0600, John A Meinel wrote:
> Since I've never worked with the bazaar pqm, I thought I would ask for a
> quick review of my changes before I do too much work. I haven't really
> tested it, I just wanted to get a feel for the code flow of pqm.
> 
> Attached is the patch, but the branch is also available here:

General feel +1.

Specific issues:
 - All new code in PQM I add tests for - pqm/tests/*.py and
pqm/ui/tests/*.py.
 - I want to decouple the parsing of scripts and the execution, your
patch doesn't really make this easier or harder, but what I have
mentally planned is that the Script will stop owning the input, instead
we will create a sequence of commands and then execute them in series.

There are a couple of features tied into this:
One is to be able to accept two merge requests in a row and then run a
single regression test run and finally commit to both branches. Again,
your patch doesn't make this harder or easier - but I wanted you to be
aware of where PQM is headed, so that if you are debating where to put
stuff, its predictable :0.

Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060224/cc6b6c82/attachment.pgp 


More information about the bazaar mailing list