[MERGE REVIEW] fixes for cmd_diff and checkouts

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> +1 on the changes. My only concern is the new function name. You called
> it "cmd_show_diff" which makes it sound like it should be a command line
> function. "bzr show-diff".
> 
> I realize you need a unique name, and we already have 'show_diff'
> (deprecated) and 'show_diff_trees'.

diff_helper?  diff_command_helper?  dwim_diff?  diff_ui?  I'm just not
good at this.

> I would also name the parameters "old_revision_spec" rather than
> "old_revision". Because it isn't a Revision object or a revision_id, it
> is a spec to search in the tree for that revision.

Sure, I can do that.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEAxnh0F+nu1YWqI0RAoAdAJ9g7RDDd/grO+Fx9tVXurrn5wGYvACdF0kf
isiLp967l2hXmAOSzz/tihk=
=QKTx
-----END PGP SIGNATURE-----