[MERGE] add modification dates to diff output, get rid of /dev/null (bug #43033)

[John A Meinel]

James Henstridge wrote:
> On 17/05/06, James Henstridge <james.henstridge at gmail.com> wrote:
>> I posted this patch a few days ago, but have updated it with a few
>> more tests, and think it is ready to merge.  The branch is available
>> here (currently at revision 1712):
>>
>>     http://people.ubuntu.com/~jamesh/bzr/bzr.diff-output
> 
> Would it be possible to get this merged (possibly with a second +1)?
> 
> The branch should merge cleanly against bzr.dev (I just did a merge
> and ran the test suite again).
> 
> James.
> 
> 

I just wanted to discuss briefly if we really want the times to be
shown. It seems to be adding a lot of clutter. And after what happened
with -p1 diffs, I would like to see us be careful about what we add to
the 'diff' output.

Probably adding timestamps is less of a pain than adding prefixes
(because it is easier to mentally throw away trailing space separated
stuff, than stuff that is attached to the path you are looking at).

I personally prefer not to have timestamps. But with them a tab
character away, they don't seem terrible.
I do find '/dev/null' to be more obvious than 1970 to indicate the file
didn't exist. We still have the === removed/added line, but it is one
less visual clue.

Should we try to have the old label be the old name in the case of
renames? It would seem not. But why in the world does patch need 2 names
then.

The code changes themselves look clean, and the test cases look
sufficient. So if we decide we really do want the timestamps, you have
my +1.

John
=:->


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060523/6c027696/attachment.pgp