[merge] catching EPIPE (especially on win32)

Aaron Bentley aaron.bentley at utoronto.ca
Thu Jun 29 04:39:16 BST 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> This isn't how CVS works. If you ^C in the middle, you get:
> cvs [log aborted]: received interrupt signal
> 
> I think it is fine for bzr to print
> bzr: interrupted

The original purpose of the display_command decorator was to swallow
KeyboardInterrupt.

There are plenty of counterexamples of commands that don't print
anything when interrupted.

The entire display_command distinction is that these commands don't do
anything, so KeyboardInterrupt and EPIPE aren't dangerous and can't lead
to errors.

> swalling KeyboardInterrupt also means that when the test suite is
> running, you can't stop it with a simple ^C.

Perhaps we should rethrow it as SilentKeyboardInterrupt or
PrettyKeyboardInterrupt, but the default handling of KeyboardInterrupt
is dead ugly, and I don't think we want to use that.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEo0tk0F+nu1YWqI0RAussAJ90tSaGiCRzGh61mDlth9EUUBox6wCggdjW
ov8Z7x7UWGKhmAL5nhq4o64=
=w9TJ
-----END PGP SIGNATURE-----




More information about the bazaar mailing list