[PING][MERGE] help topics

[Goffredo Baroncelli]

On Friday 15 September 2006 23:58, Robert Collins wrote:
> On Thu, 2006-09-14 at 13:46 -0500, John Arbash Meinel wrote:
> > The attached patch was written by Goffredo and updated by myself. It
> > adds help topics to the bzr help system. So you can type 'bzr help
> > topics' to get a list of topics. And 'bzr help revisionspec' to get the
> > currently registered revision specs.
> 
> This seems mostly reasonable. I have a few nits.
> 
> Firstly the use of two dictionaries seems like its crying out for a
> single dictionary with objects in it.
I removed one dictionary.

> Secondly, the help strings for revspec are mostly non-pep8 - they are
> missing the gap after the first line, which I think is a good discpline
> for help readability as it ensures a meanginful summary has been
> created.
Done

> It needs a NEWS entry. And perhaps mention in the intro to bzr in the
> tutorial or documentation.
Done

Now do we can get a +1 ? :-)

Goffredo


-- 
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack at inwind.it>
Key fingerprint = CE3C 7E01 6782 30A3 5B87  87C0 BB86 505C 6B2A CFF9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: help-topic.diff
Type: text/x-diff
Size: 12082 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060920/ff1d3823/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060920/ff1d3823/attachment.pgp