[merge][0.11] bugfix 56815: export unicode files to tar+zip

Robert Collins robertc at robertcollins.net
Thu Sep 21 04:19:53 BST 2006


On Wed, 2006-09-20 at 18:47 -0500, John Arbash Meinel wrote:
>        f = open('branch/hello', 'wb')
> +        try:
> +            f.write('foo')
> +        finally:
> +            f.close() 

self.build_tree_contents([('branch/hello', 'foo')])

is a more compact way to represent this.

+        f = open('branch/goodbye', 'wb')
+        try:
+            f.write('baz')
+        finally:
+            f.close()
+        tree.add('goodbye')

and likewise here.

+    def test_basic_directory_export(self):
+        self.example_branch()
+        os.chdir('branch')
+

it would be nice to nuke these chdirs in the future. how to you feel
about a new parameter to run_bzr (working_dir='branch', ...) ?

+1 for this patch for 0.11. (Though I'd prefer you change it to use
build_tree_contents before merging)

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060921/5c643fbe/attachment.pgp 


More information about the bazaar mailing list