commit performance regression in 0.11

Robert Collins robertc at robertcollins.net
Mon Sep 25 22:09:08 BST 2006


On Mon, 2006-09-25 at 13:51 -0500, John Arbash Meinel wrote:
> 
> 
> 1) We almost have the infrastructure in place to remove a
> read_inventory
> call during commit. We just need to have the commit builder return the
> RevisionTree. 

As this is a performance regression, and the fix is small in terms of
api alterations; I'm +1 for fixing this as an rc2. Please merge a fix to
bzr.dev and I will cherrypick it into 0.11.

(The fix I am expecting, and +1'ing in advance is to:
 - add a test that you can retrieve the inventory object from the commit
builder after calling commit
 - use that to obtain the tree in commit.py and call set_parent_trees
with it
 - in set_parent_trees, after calling set_parent_ids (which performs the
ghost check), set the basis - delete if the left most tree is None, or
the parent list is empty, otherwise serialise from the inventory to
disk.

This should give us a two serialisations per commit: one to the
repository and one to the local directory.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20060926/41a1f4f0/attachment.pgp 


More information about the bazaar mailing list