[REGRESSION][MERGE] Knit indexes incorrect with unicode keys

Robert Collins robertc at robertcollins.net
Tue Nov 28 08:29:10 GMT 2006


On Mon, 2006-11-27 at 22:11 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > This patch fixes a regression introduced by the utf8 cache [I think]
> > where we fail to decode unicode keys in the knit index.
> 
> +1.
> 
> I do wonder whether keeping the _cache key utf8-encoded would be a
> performance win, though.

I think we want to eventually use utf8 for all our 'conceptually
unicode' strings, and only make them unicode when we need to transcode
to a non-unicode terminal.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20061128/3913b051/attachment.pgp 


More information about the bazaar mailing list