[MERGE][0.15] Small updates for win32 support

John Arbash Meinel john at arbash-meinel.com
Mon Mar 12 16:09:46 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Aaron Bentley ?8H5B:
>>> John Arbash Meinel wrote:
>>>> Alexander Belchenko wrote:
>>>>> John Arbash Meinel ?8H5B:
>>>>> Your patch introduce new fails during selftest like this:
>>>>> ERROR: #1106 test_revert.TestRevert.test_preserve_execute
>>>>>     <WorkingTree4 of C:/Temp/jam/test0000.tmp/1K/01106/work/tree> is not locked
>>>>> And there is still some LockError exists.
>>>>> Gzipped log attached.
>>>> Well it seems a little weird to call WorkingTree.is_executable() when
>>>> you don't have a lock on the tree.
>>> Where do we stand with this work?  It looks as though this version of
>>> the patch shouldn't be merged.  Is that right?
> 
> For me it's incomplete and not ready yet. Maybe John think different.
> 
> [µ]

Well, I haven't been sending commits from my win32 machine to
bazaar-commits, but I'm fixing that.

I've switched and made 'is_executable' take a read-lock, just to make
things complete. I'm also interested in checking out your win32 fixes
which get the test suite all passing again.

I was really hoping to do that on Fri, but I got stuck debugging. And so
far today, I'm just playing catch-up with all of the wonderful patches
on BB, to make sure that they all get merged.

Attached is the current version of my win32 branch. From a desire to
continually integrate things into bzr.dev, I'd like to merge this. Since
I think it is better than what we have, and it lets me move on to the
next thing without worrying about divergence.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF9XtKJdeBCYSNAAMRAkb2AKCuyhiwN1wrCYL2BOS66zeeAjvEBQCdFg+C
ekCFaOEhwnW04LpiRPl8reg=
=FWi1
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: win32_is_executable.patch
Type: text/x-patch
Size: 16843 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070312/c50d992c/attachment.bin 


More information about the bazaar mailing list