[MERGE] Initial support for marking bugs as fixed using bzr

James Westby jw+debian at jameswestby.net
Fri Apr 13 07:52:01 BST 2007


On (12/04/07 18:07), Aaron Bentley wrote:
> James, please don't force 'bundle' to omit revisions.  Just use bzr.dev
> (or a mirror) as your submit location.
> 
> Omitting revisions breaks bundle's usefulness as a means of shipping
> revisions, because I can't use your bundle to apply your changes.  It
> also obscures the full effect of your bundle, since merging your bundle
> introduces ListOption.

You can use my bundle to apply my changes. It just requires you to have
a branch that has Jonathan's bundle already applied.

Also it doesn't obscure the effect of my bundle. My bundle has nothing
to do with ListOption. You can see what changes I want to make from the
diff in mine.

However I accept that this may not be the preferred way of working, but
I don't believe there is a policy on that yet. If we want to have one
then please say so and I will not do it again. Allow me to explain the
reasons why I chose to do it this way.

My change was to add bugs.debian.org to the new feature. I also took the
chance to refactor a little while I was there. This is a change that
builds on the work Jonathan did. Normally I would wait until it was in
bzr.dev to do this, but the deadline is approaching, and I wanted to
make sure I had plenty of time to go through a couple of review cycles.
To that end I posted an incremental change to the original, as that had
received a review, but had not been updated from that review. It seemed
best if I kept out of the way and posted just a small change that was
easier to review. I wasn't going to make changes for all of John's
comments, so I thought that having the full diff to bzr.dev would just
obscure the issue, as 90% of it would have just been what was already
reviewed.

Thanks,

James

-- 
  James Westby   --    GPG Key ID: B577FE13    --     http://jameswestby.net/
  seccure key - (3+)k7|M*edCX/.A:n*N!>|&7U.L#9E)Tu)T0>AM - secp256r1/nistp256



More information about the bazaar mailing list