[MERGE] Initial support for marking bugs as fixed using bzr

[Robert Collins]

On Mon, 2007-04-16 at 10:18 -0500, John Arbash Meinel wrote:
> 
>   a) I would at least prefer ", " as the separator, to plain ','.

Agreed. I would suggest ' ' in fact, not ', ' because a ',' is valid in
a URL (std 66 section 3.3), it only gets encoded when one is
representing a path segment containing a ','.

>   b) It assumes neither space nor comma appear in urls. comma is a
>      "reserved" character, (I think it defines a fragment like
>       semicolon)
>
>      I *think* that means we are okay. But what if a tracker wants to
>      use: "http://myurl/bugs,12345". If that is a stupid thing to do
>      (from the URL definition perspective) then I won't worry about
> it.
> 
>      But if you do (a) above, then the parser splits on ", ". Which is
>      much less likely to appear by chance. Especially since spaces
>      should be encoded for urls. (%20)

'http://foo/bar,' is a valid URL with a parameter on the bar segment. A
safe convention is to use < and > around the URL.

> 3) I had some comments about the possible BugTracker api. What you
> have
> is probably fine, but if we want to change it, we should do so before
> 0.16 is released.

I'm doing a review of this now..

Cheers,
Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070419/9133b0c0/attachment.pgp