[MERGE][0.16][bug #110399] 'bzr status' and 'bzr diff' shouldn't recurse into unknowns

Robert Collins robertc at robertcollins.net
Fri Apr 27 03:13:29 BST 2007


On Thu, 2007-04-26 at 21:07 -0500, John Arbash Meinel wrote:


> We don't follow symlinks (since we generally use os.lstat), so a cycle
> wouldn't do anything.
> 
> strace might work, but it would mean parsing the output, and I don't
> know if strace is stable on all platforms.
>
> It also requires having strace available, and I know it isn't on my Mac
> (it might be a simple port install away, though).

I think it is a simple port away. As far as the output goes, a simple
'unknowndir/subpath' not in strace.output is probably enough of a
'parse' for this test.

> Since we don't seem to have a better way, do you have a vote for the patch?

I'm +1 on the patch. I would like a bug open that this isn't tested at
the interface level though.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070427/af2bffa6/attachment.pgp 


More information about the bazaar mailing list