[MERGE] Conditionalize format warnings

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Aaron Bentley wrote:
> 
>> You can make base a required parameter of _check_supported, and issue a
>> deprecation warning if it's not provided.
> 
> Actually, since it's internal, a warning isn't strictly necessary.
> 
> Oh, also: it looks like this is an infinite loop waiting to happen:
> 
> Branch.open => BzrDir.open_branch => BzrDir._check_supported => Branch.open

It's a bit different, but I wonder whether we should move the nag to
(Tree|Branch|Repository).lock_write, after the lock succeeds?

That would prevent nags when we don't have write access, and mean that
we could avoid double-opening branches.  Obviously, we'd need to ensure
the nag only happened only once per invocation.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGVulx0F+nu1YWqI0RAtglAKCJFPH+7nOqJ3DAdl4ENJxWbVGFVwCgggOW
o7TKjh5dCbLBcI/di1dd/yk=
=dBUU
-----END PGP SIGNATURE-----