[PATCH] Prefer lstat over stat, don't chmod symlinks

Martin Pool mbp at sourcefrog.net
Wed Jun 13 00:05:37 BST 2007


On 6/12/07, Elliot Murphy <elliot at canonical.com> wrote:
> On 06/11/2007 07:40 PM, Martin Pool wrote:
> > To make sure that this works, we should add a test in test_osutils
> > that make_readonly works correctly when the target is a symlink.  (In
> > fact it looks like at the moment there are no direct tests for those
> > functions at all?)
>
> Sure thing! Here is an updated patch that includes tests for both
> make_readonly and make_writable, and verifies that they don't blow up
> when handed a dangling symlink.

Thanks.

+1 from me, any other reviews?

-- 
Martin



More information about the bazaar mailing list