[MERGE] --no-backup option for bzr upgrade (#118653)

[Robert Collins]

On Tue, 2007-07-10 at 16:41 +0200, Lukáš Lalinský wrote:
> Hi,
> 
> I was browsing bzr bugs in launchpad and was very happy to notice
> https://bugs.launchpad.net/bzr/+bug/118653, which explains that the only
> thing that is preventing branches hosted on LP from being upgraded is
> the .bzr.backup directory. So I added --no-backup option to `bzr
> upgrade` to upgrade my branches, but as I expect it might be useful to
> other people as well, I'm sending the patch also here.

Coincidentally I was sitting next to a user here at europython running
into this problem too and I just updated the bug to reflect reality :).

However --no-backup is really very dangerous; more dangerous than you
might predict.

Specifically any sort of link error will leave branches/repositories in
an unrecoverable state if no backup has been taken. Further to that some
upgrades will use the backup as the source for the upgraded data so we
may not be able to avoid it per se without changing where we make the
backup too... In my book the risk is unacceptable, and its not at all
clear to users that the backup is not being done soley to have a backup,
so for these two reasons I'm -1 on such a feature.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070711/eb17f6ac/attachment.pgp