[MERGE] delegate graph generation to knits entirely

[Martin Pool]

On 7/18/07, Robert Collins <robertc at robertcollins.net> wrote:
> On Wed, 2007-07-18 at 23:11 -0400, Martin Pool wrote:
> > Martin Pool has voted -0.
> > Status is now: Semi-approved
> > Comment:
> > It looks like you still call
> >
> > +        entire_graph = a_weave.get_graph()
> >
> > even when revision_id is not None?
>
> Blech. I've deleted that line TWICE now. With that corrected ?

Try --force ;-)

+        if revision_id not in a_weave:
             raise errors.NoSuchRevision(self, revision_id)

Maybe this should be the responsibility of a_weave.get_graph too?
(Maybe it does it already?)  Otherwise it seems likely to
unnecessarily read the index again, or at least traverse it.

Aside from that, assuming it passes, it seems ok to me.

-- 
Martin