[merge] different return code for internal errors

[Martin Pool]

Bazaar has the concept of internal vs user errors.  The first type
cause a traceback to be displayed and basically correspond to
situations that we didn't expect to happen.  The latter are things
that are (thought to be) not a bug in Bazaar but rather a problem
in the environment or the user's input.

In 0.90 both of them give an overall exit code of 3; this changes it
so that internal errors give an exit code of 4.  The main benefit
of doing this is to blackbox tests that use run_bzr_error: they
now require that Bazaar gives a nice user error, unless they
specifically give retcode=errors.EXIT_INTERNAL_ERROR.

With this in place there are in fact a few tests that fail, probably
because they are getting an error that wasn't the one they expected.

-- 
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 200708160755Z-error-exitcode.diff
Type: text/x-diff
Size: 7329 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070816/6d35f987/attachment-0001.bin