[MERGE][bug #151208] Upgrade util/configobj to version 4.4.0

Matt Nordhoff mnordhoff at mattnordhoff.com
Mon Nov 19 18:53:29 GMT 2007


Vincent Ladeuil wrote:
>>>>>> "Matt" == Matt Nordhoff <mnordhoff at mattnordhoff.com> writes:
> 
>     Matt> Vincent Ladeuil wrote:
>     >> Nothing has changed regarding bzr needs, tests are still passing,
>     >> bug #149019 (which could have been avoided by this upgrade did
>     >> not regress).
>     >> 
>     >> The code is slightly shorter, the internal tests having been
>     >> moved to a specific file.
> 
>     Matt> I know it doesn't matter, but in test_config.py, why not "from
>     Matt> bzrlib.util.configobj import configobj"? PEP 8?
> 
> I tried that but it doesn't work in that case.

Huh!

>     Matt> Also, why not try importing configobj and only use
>     Matt> bzrlib.util.configobj if it's not available?
> 
> Because we test against the embedded version and I see little
> interest in taking the risk of a backward or forward incompatible
> change.

Oh, good point. Never mind.

Still, could do it in config.py.

Anyway, I'll shut up now.
-- 



More information about the bazaar mailing list