[MERGE][#157026] Fall back to showing e-mail in ``log --short/--line`` if the committer/author has only e-mail

Lukáš Lalinský lalinsky at gmail.com
Sun Dec 2 09:10:48 GMT 2007


On So, 2007-12-01 at 09:00 -0500, Aaron Bentley wrote:
> Aaron Bentley has voted resubmit.
> Status is now: Resubmit
> Comment:
> This ought to be using email.Utils.parseaddr.  I think we didn't know 
> about it when we wrote these originally.

The problem is that it doesn't really do what LogFormatter.short_author
needs:

In [2]: email.Utils.parseaddr('John Smith')
Out[2]: ('', 'John')

I don't know whether it's a bug or a feature, but either way it doesn't
work for us.

> Also, I'd prefer if you didn't use "or" and "and" as ways of selecting 
> values.  It's not a very clear way of writing it.

I personally find "or" clear enough when selecting from the first
non-empty of two values, but I can change it if decide about the first
issue.

Lukas





More information about the bazaar mailing list