[MERGE][1.0] Fixes for find_differences() and get_parents_map()

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
>> These aren't strictly dependent on eachother, so I'd be happy to split them out
>> into separate patches. I also wanted them to be tracked separate from my
>> earlier heads() work so I'm submitting it as a cherrypick.
> 
> I really appreciate your efforts on fixing up this graph stuff, and I
> planned to review some of it tonight.  Unfortunately, none of it seems
> reviewable to me.
> 
> "Re: [MERGE][1.0] Graph.heads() optimization... Now 1770x"
>  * contains Graph._preload_parents, but later merge requests retract it

Hm... I thought I send the patches correctly. _preload_parents is only
get_parents_map wrapped around get_parents. (Turn the list into a dictionary.)
So there is no reason to have it if we have get_parents_map.

There *was* a ParentsProvider.preload_parents() function which I completely
removed. So whether on not a private helper function exists doesn't seem like
it should block a review.


> 
> "Re: [MERGE] [BUG #172657][1.0] make 'bzr status' after merge faster"
>  * I don't want this to go in until after Graph.find_differences is
>    fixed.
> 
> "[MERGE][1.0] Fixes for find_differences() and get_parents_map()"
>  * I don't think we've discussed get_parents_map enough to merge it.
> 
> Aaron

I'll try and add more discussion on it. I agree it hasn't been discussed much.

As near as I can tell, all of this missed 1.0rc3, so it doesn't really matter.
They are all pending 1.1 anyway.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD4DBQFHXpIlJdeBCYSNAAMRAkyaAKDMWnD+Dbe8bTGcxieecvWv5gzdYgCVHwad
h9btpv+EB6cF6/lwXXlT4w==
=hxBY
-----END PGP SIGNATURE-----