[MERGE] Progress bar in InterDifferingSerializer.fetch()

[Lukáš Lalinský]

On Po, 2007-12-17 at 21:09 -0500, Aaron Bentley wrote:
> Aaron Bentley has voted resubmit.
> Status is now: Resubmit
> Comment:
> Please add a test using an instrumented ProgressBar, as mentioned on the 
> list.  Also, please follow the standard set by other ProgressBar users: 
> no progress unless a ProgressBar is explicitly supplied.

Can you please point me to code that uses progress bars the right way?
Because for instance other fetchers in fetch.py do:

        if pb is None:
            self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
            self.nested_pb = self.pb
        else:
            self.pb = pb
            self.nested_pb = None

which forces a progress bar even if no was supplied. Another two uses
I've found are either with DummyProgressBar (transform.py) or 'if pb is
not None' (tree.py), but using the standard from other fetchers seems
the the best option to me.

Lukas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Toto je =?ISO-8859-1?Q?digit=E1lne?=
	=?ISO-8859-1?Q?_podp=EDsan=E1?= =?UTF-8?Q?_=C4=8Das=C5=A5?=
	=?ISO-8859-1?Q?_spr=E1vy?=
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071218/8ee28371/attachment.pgp