[MERGE] Re: Traceback using "bzr log lp:bzr-email"

[Andrew Bennetts]

John Arbash Meinel wrote:
> Andrew Bennetts wrote:
[...]
>
> -        return urlutils.relative_url(medium_base, 
> transport.base).encode('utf8')
> +        rel_url = urlutils.relative_url(medium_base, transport.base)
> +        return urlutils.unescape(rel_url).encode('utf8')
>
> ^- doing: urlutils.unescape(rel_url).encode('utf8')
> seems like a whole lot of double handling. Why not do:
>
> urllib.unquote(url)

Basically, I was aiming for consistency with how URL path components from
transports are handled elsewhere in bzrlib, but on reflection I think that was
foolish consistency.  I've changed it to just do urllib.unquote(url).

Thanks for the review.

-Andrew.