Bundling more plugins into bzrtools

[Toshio Kuratomi]

Robert Collins wrote:
> On Thu, 2008-02-14 at 10:54 -0800, Toshio Kuratomi wrote:
>>> Perhaps it'd be worth configuring bzr to look in
>>> /usr/lib/pythonX.Y/site-packages/bzrlib/plugins too for your amd64
>>> builds?
>>>
>> If bzr could do that it would be awesome!  I don't know how the
>> plugin 
>> architecture works internally but if it relies on python's import to 
>> find the plugins you'll have some code to write, though.
> 
> bzr already lookins in two locations, adding a third is easy.
> 
> Right now you could globally export BZR_PLUGINS_PATH on your system.

In 1.1 at least, the variable looks to be BZR_PLUGIN_PATH.

Is ~/.bazaar/plugins expected to behave like a system path (always 
implicitly searched)?  Right now an empty BZR_PLUGIN_PATH lets bzr find 
things in ~/.bazaar/plugins.  A non-empty BZR_PLUGIN_PATH changes that 
so only the system /usr/[...]/bzrlib/plugins/ directory is implicitly 
searched;  ~/.bazaar/plugins has to be explicitly listed in 
BZR_PLUGIN_PATH to make those plugins available.

> But
> better would be a fairly trivial patch to bzrlib.plugin to
> add /usr/lib/pythonX.Y/site-packages/bzrlib/plugins to the default
> path.
> 

Excellent!  Patch against 1.2rc1 and tested with bzr-1.1 attached.

-Toshio
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-arch-indep-plugins.patch
Type: text/x-patch
Size: 849 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080214/a2fb8810/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080214/a2fb8810/attachment.pgp