[MERGE] line-endings support: part 1 of 2: versioned properties

[Nicholas Allen]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 

| No.
|
| Although your example is make sense for me, but I think the users
| less likely tends to changes *extension* of file name rather than 
*basename*,
| or parent dir. This is why I think my approach will works for 90-95% 
cases.
I don't want to be negative about this because I think it's great the 
progress you have made on this and it really is cool to see bzr 
progressing in this area and the following is only me opinion/feedback. 
However, I don't think this wild card solution is a good one. I don't 
think bzr wants a system that works 95% of the time and has surprises in 
the other 5% of use cases. I know that this solution solves most of the 
common problems but I really want that when I rename/move something I 
don't change its properties ever (even if I rename the extension).

After thinking about this I would much prefer that bzr would store 
properties by file id *always* and not store these in a text file that 
the user can edit by hand. I would rather have a file that had automatic 
property setting when I add new files. I can always change the 
properties of multiple files using one command if I need to (or by using 
shell scripts or a fancy GUI app) and I much prefer this explicit 
approach. I would always be worried that a pattern would affect line 
ending of files I didn't mean to.

Also, imagine a repository with the following layout:

config
~    windows
~       some_config_file.txt
~   linux
~       some_config_file.txt


The config files in windows have the same extension (.txt) as the ones 
in the linux directory but they should have different line ending 
settings. This would force me to set the line ending style on every file 
as I can't do "linux/*.txt" but only "*.txt" in the pattern. This would 
create lots of conflicts too I would imagine. In a cross platform 
repository the above layout may not be uncommon and I may want to edit 
the linux config files on windows and vice versa (and if using cygwin 
maybe the files in a linux specific directory must have '\n' and not 
'\r\n').

Again, I realize you are trying to solve the majority of problems in a 
simple way and your solution does that - I just think that this is not a 
great long term solution and would cause problems if Bazaar was to adopt 
a more complete implementation in the future.

Cheers,

Nick
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
 
iD8DBQFIBHrnbpmWsXfOU58RAtn5AKCfnvNAmcBh6B8ZSQ/8QRpdZaRwbACgpJ/q
Pha8ajk4jgISL+WCqOPUcMI=
=LcmW
-----END PGP SIGNATURE-----