[MERGE] Make the test suite use the new test loader

Ian Clatworthy ian.clatworthy at internode.on.net
Mon Apr 28 12:45:58 BST 2008


Vincent Ladeuil wrote:

>     Ian> Most of the rest looks OK at first glance (but I must
>     Ian> confess I haven't dug too deeply as I'm not planning to
>     Ian> officially review it).
> 
> Well, given that this is only a *use* of the new test loader and
> that indeed your review was quite effective, I wonder what
> 'official' means in this context, but reviewer is king :)

It means "I'm confident some bit are wrong, but I'm not confident the
other bits are necessarily correct/optimal."

If someone else doesn't step forward in coming days, I'm happy to give
more time towards reviewing this. I do want to see it land but I also
think you'll get a better review from those more test-infected than me.

I'm pleased my partial review was useful nevertheless. :-)

Ian C.



More information about the bazaar mailing list