[MERGE] Accelerate no-op pull

Aaron Bentley aaron at aaronbentley.com
Wed Apr 30 02:44:34 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
>> - - It delays history retrieval until it has been shown to be needed

> get_graph() shouldn't be doing any intrinsic history retrieval, so I'm
> not sure how it delays history retrival.

Not get_graph; cmd_pull.run invoked Branch.revision_history; now it does
Repository.iter_reverse_revision_history, but only if last_revision has
changed.

> However, do all tests still pass?

Yes.

> It looks to me like this will no
> longer error on a missing revision in the source (which is part of the
> current contract) and why the current code didn't just check all
> requested items were in the target. If all tests pass:

Okie dokie.

Aaron



> 
> -Rob

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIF88C0F+nu1YWqI0RAg+iAJ4mNPzfFSArPck4g+SwxPZS1mksnQCgguY2
XH6sW+F+hK4OX6XUvjCCoyo=
=nnVj
-----END PGP SIGNATURE-----



More information about the bazaar mailing list